1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sftp/sftp.h sftp_client.c src/syncterm/ssh.c

    From Deucе@VERT to Git commit to main/sbbs/master on Thu Mar 7 12:13:22 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/69322766527512a1ef3952b5
    Modified Files:
    src/sftp/sftp.h sftp_client.c src/syncterm/ssh.c
    Log Message:
    Add sftpc_get_err() function and make the sftp client struct hidden

    This eliminates the hack of using ssh_mutex to protect members of
    sftp_state (which has its own mutex).

    This doesn't fix the problem of sftp_state itself though.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Thu Mar 7 13:50:58 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/bde52d434d8945f04d202b97
    Modified Files:
    src/sftp/sftp.h sftp_client.c src/syncterm/ssh.c
    Log Message:
    Split SFTP client cleanup into to functions.

    sftp_finish() which ends the communication, disables further
    commands, and can explicitly be called more than once, and
    sftp_end() which frees the state.

    This prevents a race around sftp_finish() calls and sftpc_*() calls
    which is likely responsibe for various weirdness in SSH connections,
    and should fix ticket 135.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net