Hello, All!
А есть какай-то ru.binkd.devel или binkd.devel эха?
Почему одобренный PR от Виталия, с фиксом дат в отладочный вывод, так и висит не смёрженным больше года
https://github.com/pgul/binkd/pull/38 ?
Я за какое-то время накопил своих фиксов и предлагаю их сюда одним коммитом.
-Begin file 0001-Squashed-commits-with-various-fixes.patch-
From 5480c96b253b52d89800fcabaf32f6451e389ce4 Mon Sep 17 00:00:00 2001
From: Nil Alexandrov <
nil.alexandrov@gmail.com>
Date: Thu, 7 Mar 2024 06:57:59 +0300
Subject: [PATCH] Squashed commits with various fixes.
* Fixed a few memory leaks.
* Fixed possible string overflows with sprint.
* Fixed possible unterminated string after strncpy.
* Fixed log messages, missed arguments, mismatches with type specifiers.
* Fixed const correctness warnings.
-+-
client.c | 3 ++-
ftnq.c | 6 +++---
ftnq.h | 2 +-
https.c | 3 ++-
inbound.c | 1 +
iptools.c | 16 ++++++++++------
ntlm/helpers.c | 1 +
perlhooks.c | 7 +++++++
protocol.c | 21 ++++++++++++---------
readcfg.c | 13 ++++++++-----
tools.c | 10 +++++-----
tools.h | 6 ++++++
12 files changed, 58 insertions(+), 31 deletions(-)
diff --git a/client.c b/client.c
index 81dfefe..bc61379 100644
--- a/client.c
+++ b/client.c
@@ -370,6 +370,7 @@ static int call0 (FTN_NODE *node, BINKD_CONFIG *config)
{
char *sp, *sport;
strncpy(host, proxy[0] ? proxy : socks, sizeof(host));
+ host[sizeof(host) - 1] = '\0';
if ((sp=strchr(host, ':')) != NULL)
{
*sp++ = '\0';
@@ -428,7 +429,7 @@ static int call0 (FTN_NODE *node, BINKD_CONFIG *config)
}
if (!binkd_exit)
{
- Log (1, "connection to %s failed");
+ Log (1, "connection to %s failed", host);
/* bad_try (&node->fa, "exec error", BAD_CALL, config); */
}
sockfd = INVALID_SOCKET;
diff --git a/ftnq.c b/ftnq.c
index dcdaef8..d211051 100644
--- a/ftnq.c
+++ b/ftnq.c
@@ -332,7 +332,7 @@ FTNQ *q_scan_boxes (FTNQ *q, FTN_ADDR *fa, int n, int to, BINKD_CONFIG *config)
strnzcpy (buf, config->bfilebox, sizeof (buf));
strnzcat (buf, PATH_SEPARATOR, sizeof (buf));
snprintf(buf + strlen(buf), sizeof(buf) - strlen(buf),
-