1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/syncterm/ssh.c

    From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Feb 12 19:10:35 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/8db8e78736120a18caca8a0d
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    Zero-Iniitalize err_len

    If call to GetAttributeString() fails, err_len can contain garbage.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Mon Feb 12 20:23:51 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/407eca73d3f48af29fcfd8aa
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    If call to GetAttributeString() fails, we have a lot worse problems
    than err_len containing garbage.

    Handle the error and mention we didn't get the message.
    While we're here, check the return value of malloc().

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Fri Feb 16 10:01:55 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/43634f586821e25e09c6e45e
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    Lower timeouts when closing SSH session.

    Reduces the time after a forced hangup that you need to wait before
    returning to the main menu.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sat Feb 17 11:39:43 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/b855aa17bcc8b2c437968d9d
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    Remove crufty code that effectively never does anything.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sat Feb 17 11:45:41 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/80c10879c30446f7f74ec6d4
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    Move sftp_channel under the ssh_mutex completely.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sat Feb 17 12:02:52 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/e7d411e01d7e8422c1ce74ee
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    Move sftp_state inside ssh_mutex.

    This won't matter now since only one thread ever touches it, but
    when cool stuff happens, it could.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Mon Feb 19 10:00:46 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/b8bc029bb50b1f05d5d26d4b
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    Expand ssh_mutex over the flushes.

    This should also resolve a conspiracy Coverity has about two input
    threads running at the same time.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Mon Feb 19 10:12:06 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/282069f99e40cfdd38fe2bf8
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    Likely fix a bunch of Coverity warnings.

    This is a very crazy lock/unlock pattern... an extra assignment
    makes it easier to follow the logic.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Tue Feb 20 05:57:47 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/c7a09e0f7ce76d9016906c9e
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    Move an sftp_state check inside mutex to silence Coverity.

    There's still outstanding issues in Coverity around sftp_state and
    sftp_channel that need some deep thought, but this one is trivial.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Wed Feb 21 06:06:48 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/abec3d19c45e767bb6757e35
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    More input thread cleanup. There was an errant lock in there.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Thu Feb 22 20:53:08 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/b73c823bc200775056bbb0cd
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    Catch when cryptFlushData() says the channel is closed.

    Also, fix an unlikely race condition. This, combined with the
    cryptlib patches, fixes various weird SSH hangs resulting from
    partial reads of the SSH packet headers... a rare event that's
    very hard to trigger. Special thanks to MeaTLoTioN for reporting
    this, and running a BBS that manages to trigger it reliably.

    Check out The Quantum Wormhole and say thanks!

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Thu Feb 22 20:53:08 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/b2041514748d0f4027763c73
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    sftp_channel is always -1 here.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Thu Mar 7 11:45:11 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/ccd73340c94c1eb688c7d561
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    Fix LOR ion error path.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Thu Mar 7 11:45:11 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/efc6e23418fbd7a19cb77759
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    Fix double-unlock and add code for impoosible situation

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Fri Mar 8 09:37:42 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/7290558b5d91b75fd34f7b8c
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    Move sftp_state setting outside of the ssh mutexes.

    Doesn't hurt anything where they were, but Coverity kinda reverse
    suggested it.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net